Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing indexes and remove unused index #3756

Merged
merged 8 commits into from
Feb 22, 2024
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Feb 14, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

alnr
alnr previously approved these changes Feb 14, 2024
jonas-jonas
jonas-jonas previously approved these changes Feb 14, 2024
@aeneasr aeneasr dismissed stale reviews from jonas-jonas and alnr via 726e758 February 14, 2024 12:40
zepatrik
zepatrik previously approved these changes Feb 21, 2024
@aeneasr
Copy link
Member Author

aeneasr commented Feb 21, 2024

https://github.com/ory/kratos/actions/runs/7901340760/job/21804831147?pr=3756#step:14:5107

🙄

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfa3074) 78.05% compared to head (c85062b) 78.36%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3756      +/-   ##
==========================================
+ Coverage   78.05%   78.36%   +0.30%     
==========================================
  Files         355      347       -8     
  Lines       24836    23903     -933     
==========================================
- Hits        19386    18731     -655     
+ Misses       3962     3761     -201     
+ Partials     1488     1411      -77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit c905f02 into master Feb 22, 2024
29 checks passed
@aeneasr aeneasr deleted the add-missing-index branch February 22, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants