Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show error page on identity mismatch #3790

Merged
merged 5 commits into from
Mar 4, 2024
Merged

fix: show error page on identity mismatch #3790

merged 5 commits into from
Mar 4, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Feb 29, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr self-assigned this Feb 29, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.10%. Comparing base (63ce470) to head (08c670f).
Report is 3 commits behind head on master.

Files Patch % Lines
continuity/container.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3790      +/-   ##
==========================================
- Coverage   78.11%   78.10%   -0.02%     
==========================================
  Files         349      349              
  Lines       24113    24113              
==========================================
- Hits        18837    18833       -4     
- Misses       3855     3859       +4     
  Partials     1421     1421              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit e6db689 into master Mar 4, 2024
26 of 29 checks passed
@aeneasr aeneasr deleted the submit-settings branch March 4, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant