Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure emails can still be sent with SMS enabled #3795

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas self-assigned this Mar 1, 2024
@jonas-jonas jonas-jonas changed the title fix: SMS courier config fix: make sure emails can still be sent with SMS enabled Mar 1, 2024
@jonas-jonas jonas-jonas marked this pull request as ready for review March 4, 2024 08:51
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.10%. Comparing base (63ce470) to head (e4d3eb7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3795      +/-   ##
==========================================
- Coverage   78.11%   78.10%   -0.02%     
==========================================
  Files         349      349              
  Lines       24113    24113              
==========================================
- Hits        18837    18833       -4     
- Misses       3855     3859       +4     
  Partials     1421     1421              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit 7c68c5a into master Mar 4, 2024
30 checks passed
@aeneasr aeneasr deleted the jonas-jonas/fixCourierConfig branch March 4, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants