Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add verification hook to login flow #3829

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas self-assigned this Mar 18, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 94.33962% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 77.96%. Comparing base (9ddf7cc) to head (a038f66).
Report is 1 commits behind head on master.

Files Patch % Lines
driver/registry_default_hooks.go 0.00% 2 Missing ⚠️
selfservice/flow/login/hook.go 97.05% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3829      +/-   ##
==========================================
+ Coverage   77.95%   77.96%   +0.01%     
==========================================
  Files         358      358              
  Lines       25165    25186      +21     
==========================================
+ Hits        19617    19636      +19     
- Misses       4041     4043       +2     
  Partials     1507     1507              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas marked this pull request as ready for review March 20, 2024 03:33
r = r.WithContext(ctx)
defer otelx.End(span, &err)
if f.RequestedAAL != identity.AuthenticatorAssuranceLevel1 {
span.AddEvent("Skipping verification hook because AAL is not 1")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an event for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't really know how else to allow making this case visible in the trace. An event is great, because it shows up as part of the span.

@aeneasr aeneasr merged commit 43e4ead into master Mar 21, 2024
30 checks passed
@aeneasr aeneasr deleted the jonas-jonas/showVerificationAfterLogin branch March 21, 2024 10:11
panbanda pushed a commit to panbanda/kratos that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants