Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use authenticate endpoint for x #3833

Merged
merged 1 commit into from
Mar 20, 2024
Merged

feat: use authenticate endpoint for x #3833

merged 1 commit into from
Mar 20, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Mar 20, 2024

Improves the "Log in with X" experience by not asking the user to re-authenticate every time.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Improves the "Log in with X" experience by not asking the user to re-authenticate every time.
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 77.97%. Comparing base (9ddf7cc) to head (e76546b).
Report is 1 commits behind head on master.

Files Patch % Lines
selfservice/strategy/oidc/provider_x.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3833      +/-   ##
==========================================
+ Coverage   77.95%   77.97%   +0.01%     
==========================================
  Files         358      358              
  Lines       25165    25169       +4     
==========================================
+ Hits        19617    19625       +8     
+ Misses       4041     4037       -4     
  Partials     1507     1507              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit 3d9ba5d into master Mar 20, 2024
28 of 29 checks passed
@aeneasr aeneasr deleted the improve-x branch March 20, 2024 09:58
panbanda pushed a commit to panbanda/kratos that referenced this pull request Mar 25, 2024
Improves the "Log in with X" experience by not asking the user to re-authenticate every time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant