Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expand identity in session extension #3843

Merged
merged 1 commit into from
Mar 24, 2024
Merged

fix: expand identity in session extension #3843

merged 1 commit into from
Mar 24, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Mar 24, 2024

Closes #3842

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr changed the title fix(sdk): expand identity in session extension fix: expand identity in session extension Mar 24, 2024
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.01%. Comparing base (cd92f2a) to head (0549b29).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3843      +/-   ##
==========================================
+ Coverage   77.98%   78.01%   +0.03%     
==========================================
  Files         359      358       -1     
  Lines       25187    25190       +3     
==========================================
+ Hits        19641    19652      +11     
+ Misses       4039     4032       -7     
+ Partials     1507     1506       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit 04f0231 into master Mar 24, 2024
22 of 25 checks passed
@aeneasr aeneasr deleted the fix-3842 branch March 24, 2024 10:16
panbanda pushed a commit to panbanda/kratos that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAPI spec does not allow nullable identity in session model
1 participant