Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't treat passkeys as AAL2 #3853

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Mar 26, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from jonas-jonas March 26, 2024 12:31
@hperl hperl self-assigned this Mar 26, 2024
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, as we don't know how the passkey was secured.

Why did we not do it initially though?

@hperl hperl enabled auto-merge (squash) March 26, 2024 12:46
@hperl
Copy link
Contributor Author

hperl commented Mar 26, 2024

Fine by me, as we don't know how the passkey was secured.

Why did we not do it initially though?

It was an oversight by me.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.99%. Comparing base (5aad1c1) to head (30f45ab).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3853      +/-   ##
==========================================
+ Coverage   77.95%   77.99%   +0.04%     
==========================================
  Files         359      359              
  Lines       25203    25203              
==========================================
+ Hits        19646    19658      +12     
+ Misses       4049     4037      -12     
  Partials     1508     1508              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hperl hperl merged commit 8eee972 into master Mar 26, 2024
25 checks passed
@hperl hperl deleted the hperl/fix-passkey-available-aal branch March 26, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants