Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webhook transient payload in OIDC login flows #3857

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Mar 27, 2024

This fixes a bug where we did not put the transient payload into the continuity container on OIDC logins, which caused OIDC login flows to lose the transient payload.

Also, this PR adds more webhook tests in general and a handy hooktest package to test webhooks.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from aeneasr as a code owner March 27, 2024 18:56
@hperl hperl requested a review from jonas-jonas March 27, 2024 18:56
@hperl hperl requested a review from zepatrik as a code owner March 27, 2024 18:56
@hperl hperl self-assigned this Mar 27, 2024
jonas-jonas
jonas-jonas previously approved these changes Mar 27, 2024
Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@hperl hperl enabled auto-merge (squash) March 28, 2024 07:10
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.04%. Comparing base (da90502) to head (8b82e67).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3857      +/-   ##
==========================================
+ Coverage   77.98%   78.04%   +0.06%     
==========================================
  Files         359      360       +1     
  Lines       25203    25233      +30     
==========================================
+ Hits        19654    19694      +40     
+ Misses       4041     4033       -8     
+ Partials     1508     1506       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hperl hperl merged commit 2cdfc70 into master Mar 28, 2024
29 checks passed
@hperl hperl deleted the hperl/fix-oidc-webhook-transient-payload branch March 28, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants