Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: linkedin issuer override #3875

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: linkedin issuer override #3875

merged 1 commit into from
Apr 16, 2024

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Apr 16, 2024

This fixes the linkedin provider, which now reports the correct issuer URL.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl self-assigned this Apr 16, 2024
@hperl hperl marked this pull request as ready for review April 16, 2024 12:24
@hperl hperl force-pushed the hperl/fix-linkedin-issuer branch from c46fa5d to 6c51e2c Compare April 16, 2024 12:31
@hperl hperl requested review from alnr and jonas-jonas April 16, 2024 12:39
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.04%. Comparing base (660f330) to head (6c51e2c).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3875      +/-   ##
==========================================
- Coverage   78.05%   78.04%   -0.02%     
==========================================
  Files         360      360              
  Lines       25205    25197       -8     
==========================================
- Hits        19675    19665      -10     
  Misses       4027     4027              
- Partials     1503     1505       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hperl hperl merged commit 11d221a into master Apr 16, 2024
29 checks passed
@hperl hperl deleted the hperl/fix-linkedin-issuer branch April 16, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants