Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydra sdk version #3904

Open
4 of 5 tasks
nsklikas opened this issue May 1, 2024 · 1 comment
Open
4 of 5 tasks

Hydra sdk version #3904

nsklikas opened this issue May 1, 2024 · 1 comment
Labels
bug Something is not working.

Comments

@nsklikas
Copy link

nsklikas commented May 1, 2024

Preflight checklist

Describe the bug

The hydra sdk version defined in go.mod (https://github.com/ory/kratos/blob/master/go.mod#L76) points to a commit (ory/hydra-client-go@1c7b57df3bb0) that is not under the master branch. This was introduced by #3729.

This commit seems to include a lot of changes, like disallowing extra parameters in the hydra response, that are not part of the master branch. I assume that the change was not intentional, so I would suggest to change it to install v2.2.0 of the hydra sdk.

I can open a PR to fix it, if you want.

Version

v1.1.0

@shipperizer
Copy link

@hperl is there any plan in addressing this?

would you accept contributions to fix the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

2 participants