Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add case to ensure correct behavior when verifying a different email address #999

Merged
merged 5 commits into from
Jan 25, 2021

Conversation

zepatrik
Copy link
Member

@decker502 can you please check if this is exactly your steps described in #998 ? If not, can you open a PR against this branch to correct it? For me, this is failing locally as expected. You can run this yourself:

$ npm i
$ ./test/e2e/run.sh --dev sqlite verification

@zepatrik zepatrik marked this pull request as draft January 21, 2021 11:33
@decker502
Copy link

According to this test case, there is indeed no problem. I need some time to confirm whether the test case is consistent with the version of Kratos I am using. Thx!

@aeneasr
Copy link
Member

aeneasr commented Jan 23, 2021

@zepatrik could you solve the e2e issue so that we can merge this and ensure that there is no future regression regarding this?

@zepatrik zepatrik marked this pull request as ready for review January 25, 2021 09:37
@zepatrik zepatrik changed the title test: try to reproduce #998 test: add case to ensure correct behavior when verifying a different email address Jan 25, 2021
@zepatrik zepatrik requested a review from aeneasr January 25, 2021 10:30
@aeneasr aeneasr merged commit f95a117 into master Jan 25, 2021
@aeneasr aeneasr deleted the repro-998 branch January 25, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants