pipeline/authn: add unit test for token_from->cookie for both jwt and oauth2_introspection authenticators (#330) #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… oauth2_introspection authenticators (ory#330) Update the schemas to add missing cookie config element Signed-off-by: Grigoriev, Nikolai <ngrigoriev@gmail.com>
|
Nice! This looks good - as I mentioned in the docs PR I'd like the schema changes to be updated here as well, otherwise this is good to go! |
|
OK, I have verified the difference - for the affected section there was an empty line that I slipped into the schema in the docs repository. Since I have reverted the change there, this should be good, I think. BTW, I have noticed that the schema files in docs and here are slightly different, looks like the arrays are formatted differently. |
|
Ok perfect!
Yeah we're prettifying the files in ory/docs which can lead to slightly different formatting :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipeline/authn: add unit test for token_from->cookie for both jwt and oauth2_introspection authenticators (#330)
Update the schemas to add missing cookie config element
Signed-off-by: Grigoriev, Nikolai ngrigoriev@gmail.com
Proposed changes
Add both negative and positive unit tests for both authenticators for "cookie" token origin
Checklist
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.