Skip to content

Latest commit

 

History

History
168 lines (106 loc) · 7.23 KB

CONTRIBUTING.md

File metadata and controls

168 lines (106 loc) · 7.23 KB
Raw

Contributing to Ground

This guide describes how to contribute to the Ground open-source project. Please read it in its entirety before you begin.

First-time setup:

  1. Read the Code of Conduct
  2. Read and accept the Contributor License Agreement
  3. Clone the repo
  4. Set up your environment
  5. Build and run the app

Contributing to Ground:

  1. Claim an issue
  2. Create a new branch
  3. Iterate on your change
  4. Create a pull request

Note: This guide assumes you are comfortable working with Git and GitHub. If you're new to Git and/or GitHub, check out Quickstart - GitHub Docs to help you get started.

First time setup

Code of Conduct

Help us keep the Ground project open and inclusive. Please read and follow Google's Open Source Community Guidelines when contributing.

Contributor License Agreement (CLA)

Contributions to this project must be accompanied by a Contributor License Agreement. You (or your employer) retain the copyright to your contribution; this agreement gives us permission to use and redistribute your contributions as part of the project. Head over to https://cla.developers.google.com/ to see your current agreements on file or to sign a new one.

You generally only need to submit a CLA once, so if you've already submitted one (even if it was for a different project), you probably don't need to do it again.

Cloning the repo

The following instructions describe how to fork this repository in order to contribute to the Ground codebase. If you are a maintainer on the Ground core team, follow the instructions under Maintainers. Community contributors should instead proceed as described in Community contributors.

Maintainers

Maintainers may push directly to branches in the google/ground-platform, and so they do not need to fork the repo. Simply clone the repo with:

git clone https://github.com/google/ground-platform.git

Community contributors

  1. Fork this repository.

  2. Clone the new fork to your local device:

    git clone https://github.com/<user>/ground-platform.git`

    Where <user> is your GitHub username.

  3. To be able to pull changes from upstream, add the base repository as a remote:

    git remote add upstream https://github.com/google/ground-platform.git

    You can then pull future upstream changes into your local clone with git pull upstream master.

Setting up your environment

Note: This guide assumes nvm (Node Version Manager) will be used to install and manage Node.js versions. For more information on nvm, including installation instructions, see https://github.com/creationix/nvm#installation>

Install Node.js using:

nvm install 16

Building and running the app

Running locally

To get up and running quickly, you can run the web app and Cloud Functions,locally using the Firebase Local Emulator Suite.

To install dependencies, build, and run Ground locally:

npm install && npm run build:local && npm run start:local

Once the local server is ready, the app will be available at http://localhost:5000. The Firebase Emulator Suite UI can be accessed at http://localhost:4000. Changes to the web app in web/ and to Cloud Functions in functions/ are automatially rebuilt and reloaded on save.

Note: The local build variant does not require API keys to run. Warnings related to missing API keys are expected. Authentication is also disabled.

The local emulator is preloaded with a demo Ground survey. Run npm run export:local to persist changes to update the snapshot of demo data in the local db.

Using live Firebase

Alternatively, you can test and deploy against a real Firebase project:

  1. Create a project as described in Getting started with Firebase in the Firebase docs, or contact your administrator to get access to existing development and/or production projects. When creating a new project, be sure the following are enabled under "Build":
  • Authentication > Sign-in method > Google
  • Firestore Database
  • Hosting
  • Storage

  1. Create a web app under "Project Overview > Add app > Web" or choose an existing web one.

  2. Scroll down to the code snippet under "SDK setup and configuration" and select "Config". Copy the code into web/src/environments/.firebase-config.ts, prepending the keyword export to the snippet, for example:

    export const firebaseConfig = {
  apiKey: 'soMeReallYlOngApIkeyWouLdGoHere123',
  authDomain: 'my-app.firebaseapp.com',
  databaseURL: 'https://my-app.firebaseio.com',
  projectId: 'my-app',
  storageBucket: 'my-app.appspot.com',
  messagingSenderId: '12345678',
  appId: '1:12345678:web:abc123etcetc',
};

  3. Build and deploy all the things dev Firebase:

    npm install && npm run build:dev && npm run deploy <project-id>

Once complete, the web app will be available at dev project's Firebase Hosting URL.

The web app may also be develop locally against the dev Firebase server with:

cd web && npm run start:dev

The web app will be accessible at http://localhost:4200. The app will be rebuilt and reloaded changes are saved.

See <firebase/README.md> and <web/README.md> for additional npm development script commands.

Developing Ground

Claiming an issue

Before you begin work on a change, comment on one of the open issues saying you'd like to take it on. If one does not exist, you can also create one here.

Creating a branch

We strongly encourage contributors to create a separate branch for each pull request. Maintainers working directly in google/ground-platform should create branches with names in the form <username>/<issue-no>/<short-desc>. For example:

git checkout -d gino-m/1234/fix-save-button

Creating a pull request

All submissions require review and approval by at least one maintainer. The same rule also applies to mainatiners themselves. We use GitHub pull requests for this purpose.

When creating a new pull request from one of the provide templates, be sure to replace template fields, especially the PR title and Fixes #<issue no> field in the comment field.

For more information about creating pull requests, see https://help.github.com/articles/creating-a-pull-request/. To learn more about referencing issues in your pull request or commit messages, see https://help.github.com/articles/closing-issues-using-keywords/.

> :exclamation: Any subsequent changes committed to the branch you used
> to open your PR are automatically included in the PR. If you've opened a
> PR but would like to continue to work on unrelated changes, be sure to
> start a new branch to track those changes.