Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: horizontal alignment of the indicator #136

Merged
merged 3 commits into from
Jul 18, 2023
Merged

fix: horizontal alignment of the indicator #136

merged 3 commits into from
Jul 18, 2023

Conversation

Zviki-Zaks
Copy link
Contributor

@Zviki-Zaks Zviki-Zaks commented Jul 14, 2023 •
edited by baruchiro
Loading

Fixes #135

Before:

image

After:

image

@baruchiro
Copy link
Collaborator

baruchiro commented Jul 16, 2023 •
edited
Loading

Hi @Zviki-Zaks , thank you for your contribution!

I'm not sure (and we need a test for that), but I think there is a reason for this inline-block. Can you please check what happened if you're trying to select all the text in the line, with your style?

I mean, the requirement of copying a text without copying the "issue counter" added by Overlay is mainly for code elements, but I don't know if your change affects code elements too.

@baruchiro baruchiro self-requested a review July 16, 2023 08:12
baruchiro
baruchiro previously approved these changes Jul 18, 2023
View reviewed changes
@baruchiro baruchiro dismissed their stale review July 18, 2023 10:42

want to add a comment

baruchiro
baruchiro approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WELCOME!
Thank you, good work!!
JimCarreyWorkGIF

@baruchiro baruchiro changed the title Horizontal alignment of the indicator in Stackoverflow, when applied around a link. fix: horizontal alignment of the indicator Jul 18, 2023
@baruchiro baruchiro enabled auto-merge July 18, 2023 11:24
@baruchiro baruchiro added this pull request to the merge queue Jul 18, 2023
Merged via the queue into os-scar:master with commit dcdf44f Jul 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baruchiro baruchiro baruchiro approved these changes

Assignees

@Zviki-Zaks Zviki-Zaks

Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Horizontal alignment of the indicator in Stackoverflow, when applied around a link.
2 participants
@Zviki-Zaks @baruchiro