Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome says Overlay is accessing to the browser history #147

Open
baruchiro opened this issue Aug 4, 2023 · 3 comments
Open

Chrome says Overlay is accessing to the browser history #147

baruchiro opened this issue Aug 4, 2023 · 3 comments

Comments

@baruchiro
Copy link
Collaborator

baruchiro commented Aug 4, 2023

image

A quick research gave me this information:

The tabs permission will add a warning of Read your browsing history, that's because I can listen to chrome.tabs.onUpdate and record the active browser history, from now on.

I see the best practice is to use activeTab, we should check if we can use it instead of tabs.

Links:

"permissions": ["storage", "tabs"],

Chrome extension tabs permissions shows "Read your browsing history"
The tabs warning
Use the activeTab permission

Originally posted by @baruchiro in #145 (comment)

What to do

You need to change the tab permission on the manifest files to activeTab.

Overlay is accessing all tabs when the user changing the settings from the Popup, but changing the permission will break it.
Instead, we need to use tabs.onActivated to actively check if the setting changed when a tab becomes active.

Also, check other usages of browser.tabs are not broken.

@aviv1620
Copy link
Contributor

"when the user changing the settings from the Popup"
What popup is this?

@baruchiro
Copy link
Collaborator Author

The extension popup developed in src/popup

@aviv1620
Copy link
Contributor

can you add screenshot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants