-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: yarn argument value identified as a package #166
fix: yarn argument value identified as a package #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the definition of done (the checklist) on #156
Sorry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every time I think something is a simple fix, but nothing in the shared.js
file is simple for newcomers (and even for me, after long time). We need to refactor it to be simpler but it is not the scope.
I hope you will find the way to improve your contribution after my comment
Please let me know if you need help to complete this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
Fixes #156
In case of Number, handle it as Argument and skip this word.
![Screen Shot 2024-02-18 at 21 42 13](https://private-user-images.githubusercontent.com/6542413/305742296-02c26ac7-62d4-4ba0-886b-3a3b1ec0df6b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxMzE5MTQsIm5iZiI6MTcyNjEzMTYxNCwicGF0aCI6Ii82NTQyNDEzLzMwNTc0MjI5Ni0wMmMyNmFjNy02MmQ0LTRiYTAtODg2Yi0zYTNiMWVjMGRmNmIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MTJUMDkwMDE0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTg4NzZjNmZmOWM3NTMwMmM1M2QyZDdmMTE4NGFjN2EzY2JjOTY2YWRlYmEwYmYyMWViYmE3MTRlOTc1OGFiYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.Tq-ZzObNifhbnz1bhxH2Falq3YY6QxJ066HUsLbXWzo)
After the fix: