Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support npm-init and npx commands #89

Merged
merged 14 commits into from
Jun 11, 2023
Merged

feat: support npm-init and npx commands #89

merged 14 commits into from
Jun 11, 2023

Conversation

hagarfisher
Copy link
Contributor

@hagarfisher hagarfisher commented May 24, 2023 •
edited by baruchiro
Loading

Support npx, npm exec, npm create, npm init, yarn create.

Close #37

@hagarfisher hagarfisher changed the title Hagarfisher/issue37 feat: support npm-init and npx commands May 24, 2023
@baruchiro
Copy link
Collaborator

Thanks @hagarfisher!!

I will check it on Sunday.

baruchiro
baruchiro reviewed May 28, 2023
View reviewed changes
Copy link
Collaborator

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a wide range of unit tests in src/content/stackoverflow/finder.test.js, please add as many use cases as you can think of. (since with regex it is hard to predict which cases are included).

src/content/registry/npm.js Outdated Show resolved Hide resolved
src/content/registry/npm.js Outdated Show resolved Hide resolved
@baruchiro
Copy link
Collaborator

@hagarfisher Please contact me on Discord or Linkedin for free speech. I want to understand your plans and if I can help you with some code.

@baruchiro baruchiro marked this pull request as ready for review June 9, 2023 11:48
@baruchiro baruchiro merged commit 288292e into os-scar:master Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baruchiro baruchiro baruchiro left review comments

Assignees
No one assigned
Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support npm-init and npx commands
2 participants
@hagarfisher @baruchiro