Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get packages to build only from commit context #291

Open
cbix opened this issue Oct 22, 2023 · 1 comment
Open

Get packages to build only from commit context #291

cbix opened this issue Oct 22, 2023 · 1 comment
Assignees
@cbix
Labels
bug Something isn't working tooling Scripts or CI

Comments

@cbix
Copy link
Member

cbix commented Oct 22, 2023

Currently the CI checks out the specific commit for that run and compares all package versions to the current versions in the package database. This causes several issues:

  • pipelines are not reproducible as their context depends on external information in the live database
  • restarting a successful pipeline won't build any package
  • multiple parallel pipelines have undefined behavior and often build unnecessary packages
@cbix cbix added bug Something isn't working tooling Scripts or CI labels Oct 22, 2023
@cbix cbix self-assigned this Oct 22, 2023
@cbix
Copy link
Member Author

cbix commented Mar 16, 2024

This was partially addressed in #324 but we're still mixing up responsibilities:

  • git diff should determine packages to build
  • db check should determine packages to upload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbix cbix

Labels
bug Something isn't working tooling Scripts or CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cbix