Wizard: Add Hostname expandable to Review step (HMS-5177) #2674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/jira-epic HMS-5164 |
schutzbot
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2674 +/- ##
==========================================
+ Coverage 85.20% 85.23% +0.02%
==========================================
Files 175 175
Lines 20221 20255 +34
Branches 1971 1976 +5
==========================================
+ Hits 17230 17264 +34
Misses 2969 2969
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
|
Can I move out of draft once #2672 goes in? |
regexowl
force-pushed
the
hostname-review
branch
from
6fece5d to
295090d
Compare
Yup! I might even leave the partial PRs as ready for review by default if the functionality is already there. The only blocker is usually the rebase 🤔 |
regexowl
force-pushed
the
hostname-review
branch
from
295090d to
ee0134a
Compare
This adds a new expandable to the Review step.
regexowl
force-pushed
the
hostname-review
branch
from
863a9e7 to
34507b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new expandable to the Review step.
Based on and blocked by #2672
JIRA: HMS-5177