Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test osbuild module schemas with osbuild CLI #482

Open
achilleas-k opened this issue Feb 28, 2024 · 0 comments
Open

Test osbuild module schemas with osbuild CLI #482

achilleas-k opened this issue Feb 28, 2024 · 0 comments

Comments

@achilleas-k
Copy link
Member

Add unit tests for each osbuild module that generates a minimal manifest and checks it against osbuild for validation to verify that our schemas are correct.

We could even probably fuzz this kind of test. If our schemas, serialisers, and validators in this repo are correct, creating a stage should either return an error (or panic) if the values are invalid or should succeed against osbuild --inspect.

One thing that might be useful to test (in general) is that our sources/inputs/stages render to the expected json that osbuild needs. Having such tests would allow us to refactor how stages generate json and we would have a corpus of valid/expected json to double check against. And arguable it's the most important aspect of the stages/inputs/sources - that they render to osbuild json. But just an idle though/converstaion topic, not something that need to change in this PR of course :)

Originally posted by @mvo5 in #448 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant