Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why net.ifnames=0 is used ? #620

Open
Et7f3 opened this issue Apr 21, 2024 · 4 comments
Open

Why net.ifnames=0 is used ? #620

Et7f3 opened this issue Apr 21, 2024 · 4 comments

Comments

@Et7f3
Copy link

Et7f3 commented Apr 21, 2024

I digged the git history: I come to this commit (I didn't find a related PR so I open this issue). It seems to be added as an example of customization and then copied from version to version without thinking about it.

2225463#diff-de240f0bca8f03daafeb653ff429aafa12f43b5e0dc8ba327c56108a6ff864f3R70

Original issue is I can't change it:

# grep -r ifname /etc
/etc/default/grub:GRUB_CMDLINE_LINUX="console=tty0 console=ttyS0,115200n8 no_timer_check net.ifnames=1"
grep: /etc/udev/hwdb.bin: binary file matches
/etc/kernel/cmdline:root=UUID=020df4af-98fd-4818-933d-321ce6635b45 console=tty0 console=ttyS0,115200n8 no_timer_check net.ifnames=1

regen grub config and reinstall kernel-core to trigger dracut regeneration.

@Et7f3 Et7f3 changed the title Why net.ifnames=0 is required ? Why net.ifnames=0 is used ? Apr 21, 2024
@achilleas-k
Copy link
Member

achilleas-k commented Apr 22, 2024

This will change in Fedora 41: https://fedoraproject.org/wiki/Changes/EnableConsistentDeviceNamingCloud

As for the history of the option: I can't really say with absolute certainty, but it was likely added to replicate the official Fedora cloud images. This comment in the change proposal discussion thread links to the oldest surviving instance of the change being introduced in the official Fedora kickstarts.

@supakeen
Copy link
Member

This will change in Fedora 41: https://fedoraproject.org/wiki/Changes/EnableConsistentDeviceNamingCloud

As for the history of the option: I can't really say with absolute certainty, but it was likely added to replicate the official Fedora cloud images. This comment in the change proposal discussion thread links to the oldest surviving instance of the change being introduced in the official Fedora kickstarts.

Heh, the change proposal you linked says that current Fedora's except cloud use consistent device naming so it seems to confirm that our definitions would be wrong for anything not-cloud?

@achilleas-k
Copy link
Member

Yes, I think the issue started by replicating cloud configs and then it carried over to non-cloud images.

@achilleas-k
Copy link
Member

What I want to do, in preparation of the change (especially for RHEL 9.x in prep for RHEL 10) is to make it configurable. We could detect when the option is added to the blueprint and remove it from the defaults, otherwise use the default for each distro version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants