Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unattended ISO should not auto-reboot #230

Open
cgwalters opened this issue Mar 4, 2024 · 3 comments · May be fixed by osbuild/images#714
Open

Unattended ISO should not auto-reboot #230

cgwalters opened this issue Mar 4, 2024 · 3 comments · May be fixed by osbuild/images#714
Labels
area/anaconda-iso Issues relating to the unattended Anaconda ISO bug Something isn't working

Comments

@cgwalters
Copy link
Contributor

https://github.com/osbuild/images/blob/32bd652a96b5cc3ebb0066c29a2086fd6ce48913/pkg/manifest/anaconda_installer_iso_tree.go#L452 will create a boot loop when used with an ISO dd'd to a USB stick (this is really the default, I doubt anyone uses physical ISOs in real CD-ROM drives anymore) because we can't "eject" the USB key.

This is also part of a general problem that the kickstart has zero configurability.
@cgwalters cgwalters added bug Something isn't working area/anaconda-iso Issues relating to the unattended Anaconda ISO labels Mar 4, 2024
@cdrage
Copy link
Contributor

cdrage commented May 22, 2024 •
edited

@cgwalters ran into this issue earlier where after doing an unattended download it would forever reboot and my server would do a loud BEEP and reboot again..

Thought it had finished installing, but nope.

Would like to have this feature in as it'll help with installs on monitor-less servers!

mvo5 added a commit to mvo5/images that referenced this issue May 27, 2024
@mvo5
manifest: switch to halt --eject to avoid auto-reboot
4eb6c46 
In issue osbuild#230 it was raised that it is undesirable to automatically
reboot when the install is finished. So instead halt the install
and show a message to the user.

Closes: osbuild/bootc-image-builder#230
mvo5 added a commit to mvo5/bootc-image-builder that referenced this issue May 27, 2024
@mvo5
test: detect finished install via DEVICE_TRAY_MOVED event
e0d9157 
The old images code would auto-reboot after an ISO install so
the test code triggered on qmp:RESET. However with the change
to not auto-reboot [0] this is no longer feasible and we
need to detect `DEVICE_TRAY_MOVED` events that are emited
when kickstart calls `halt --eject`.

[0] osbuild#230
mvo5 added a commit to mvo5/images that referenced this issue May 27, 2024
@mvo5
manifest: switch to halt --eject to avoid auto-reboot
3dde8b9 
In issue osbuild#230 it was raised that it is undesirable to automatically
reboot when the install is finished. So instead halt the install
and show a message to the user.

Closes: osbuild/bootc-image-builder#230
@mvo5
Copy link
Collaborator

mvo5 commented May 27, 2024

Thanks for this bugreport. I was looking into this morning and two questions came up:

  1. It changes the existing behavior so users who rely on the auto-reboot (like our tests) will fail, I was looking into detecting a finished install via qmp:DEVICE_TRAY_MOVED events but that does not work as the eject happens only during shutdown and after the user pressed a key. I guess an alternative would be to switch to "shutdown" (which is also not ideal) or we add something like an artificial RTC_CHANGE(offset:-1) in the osbuild.ks to signal that the install is done for the tests (but other ideas welcome of course!)
  2. It is unclear to me if that is the behavior we want, instead we could keep the automatic reboot but instead refuse to auto-install on a disk that already has partitions. The existing behavior of just unconditionally wiping the disk seems risky. But of course that is also a behavioral change.

@mvo5 mvo5 mentioned this issue May 27, 2024
Closed
@cgwalters
Copy link
Contributor Author

cgwalters commented May 27, 2024 via email

@mvo5 mvo5 linked a pull request May 27, 2024 that will close this issue
Open
mvo5 added a commit to mvo5/images that referenced this issue Aug 1, 2024
@mvo5
manifest: switch to halt --eject to avoid auto-reboot
5e9892f 
In issue osbuild#230 it was raised that it is undesirable to automatically
reboot when the install is finished. So instead halt the install
and show a message to the user.

Closes: osbuild/bootc-image-builder#230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/anaconda-iso Issues relating to the unattended Anaconda ISO bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

manifest: wait for user input before rebooting when creating a bootc installer mvo5/images
3 participants
@cgwalters @mvo5 @cdrage