From 39df429cf421d05ac20feb728c8ce0fc6cc3890a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lars=20G=C3=B6ttgens?= <lars.goettgens@rwth-aachen.de>
Date: Thu, 29 Jun 2023 11:51:33 +0200
Subject: [PATCH] Address comments

---
 src/Rings/orderings.jl | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/src/Rings/orderings.jl b/src/Rings/orderings.jl
index c10bc06eb31e..84484f00fdf5 100644
--- a/src/Rings/orderings.jl
+++ b/src/Rings/orderings.jl
@@ -169,16 +169,12 @@ end
 """
 Orderings actually applied to polynomial rings (as opposed to variable indices)
 """
-@attributes mutable struct MonomialOrdering{S}
+mutable struct MonomialOrdering{S}
   R::S
   o::AbsGenOrdering
   is_total::Bool
   is_total_is_known::Bool
-
-  # default constructor for @attributes
-  function MonomialOrdering{S}(R::S, o::AbsGenOrdering, is_total::Bool, is_total_is_known::Bool) where S
-    return new{S}(R, o, is_total, is_total_is_known)
-  end
+  canonical_matrix::ZZMatrix
 end
 
 function MonomialOrdering(R::S, o::AbsGenOrdering) where S
@@ -1317,8 +1313,11 @@ julia> canonical_matrix(o2)
 [0   -1   0]
 ```
 """
-@attr ZZMatrix function canonical_matrix(M::MonomialOrdering)
-  return canonical_matrix(nvars(base_ring(M)), M.o)
+function canonical_matrix(M::MonomialOrdering)
+  if !isdefined(M, :canonical_matrix)
+    M.canonical_matrix = canonical_matrix(nvars(base_ring(M)), M.o)
+  end
+  return M.canonical_matrix
 end
 
 import Base.==