From 995942dbb98e10630fc6d71467cd7b775954d0cd Mon Sep 17 00:00:00 2001
From: Tommy Hofmann <thofma@gmail.com>
Date: Wed, 2 Aug 2023 07:09:02 +0200
Subject: [PATCH] Add absolute_automorphism_group(::Type{PermGroup}, ...)
 (#2458)

---
 Project.toml                             |  2 +-
 experimental/GModule/GaloisCohomology.jl |  5 +++++
 test/NumberTheory/nmbthy.jl              | 11 +++++++++++
 3 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/Project.toml b/Project.toml
index b6b2cc700995..93d36d148e3c 100644
--- a/Project.toml
+++ b/Project.toml
@@ -28,7 +28,7 @@ AbstractAlgebra = "0.31.0"
 AlgebraicSolving = "0.3.3"
 DocStringExtensions = "0.8, 0.9"
 GAP = "0.9.4"
-Hecke = "0.19.7"
+Hecke = "0.19.12"
 JSON = "^0.20, ^0.21"
 Nemo = "0.35.1"
 Polymake = "0.11.1"
diff --git a/experimental/GModule/GaloisCohomology.jl b/experimental/GModule/GaloisCohomology.jl
index 0e52f8c8af22..9eef6fc01af3 100644
--- a/experimental/GModule/GaloisCohomology.jl
+++ b/experimental/GModule/GaloisCohomology.jl
@@ -56,6 +56,11 @@ function Oscar.automorphism_group(::Type{PermGroup}, K, k)
   return codomain(mH), mmH
 end
 
+function Oscar.absolute_automorphism_group(::Type{PermGroup}, k)
+  G, mG = absolute_automorphism_group(k)
+  mH = isomorphism(PermGroup, G)
+  return codomain(mH), inv(mH)*mG
+end
 
 """
 The natural `ZZ[H]` module where `H`, a subgroup of the
diff --git a/test/NumberTheory/nmbthy.jl b/test/NumberTheory/nmbthy.jl
index 1f081a860b76..f882f3a9d4a9 100644
--- a/test/NumberTheory/nmbthy.jl
+++ b/test/NumberTheory/nmbthy.jl
@@ -30,3 +30,14 @@ end
   F2 = GF(3,5);
   @test_throws AssertionError disc_log(gen(F), gen(F2))
 end
+
+begin
+  Qx, x = QQ["x"]
+  k, a = number_field(x^2 - 18, "a")
+  kt, t = k["t"];
+  K, b = number_field(t^4 + (a + 6)*t^2 + 2a + 9, "b")
+  G, m = automorphism_group(PermGroup, K)
+  h = m(one(G))
+  @test h(b) == b && h(K(a)) == K(a)
+  @test order(G) == 4 && is_cyclic(G)
+end