Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Laurent Mpoly elem and ideals to serialization #2592

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

antonydellavecchia
Copy link
Collaborator

Added Laurent Mpoly elem and ideals to serialization

@thofma
Copy link
Collaborator

thofma commented Jul 27, 2023

A test would be nice

Copy link
Member

@micjoswig micjoswig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, with one exception (which is not actually about the serialization).

@thofma The name of the type AbstractAlgebra.Generic.LaurentMPolyWrapRing does not look very OSCAR-ish. Can't that be exported as LaurentMPolyRing or such?

@lgoettgens
Copy link
Member

Code looks good to me, with one exception (which is not actually about the serialization).

@thofma The name of the type AbstractAlgebra.Generic.LaurentMPolyWrapRing does not look very OSCAR-ish. Can't that be exported as LaurentMPolyRing or such?

This has been discussed recently on slack. See https://oscar-system.slack.com/archives/C5B2H11BQ/p1690446806159369?thread_ts=1690446806.159369&cid=C5B2H11BQ
@joschmitt asked for the same, but the solution seems to be a lot more involved than expected (rename most of AbstractAlgebras structs and update everything downstream).

@thofma
Copy link
Collaborator

thofma commented Aug 1, 2023

Just to elaborate a bit more on what @lgoettgens said. There is already a LaurentMPolyRing, so we cannot just rename it.

@thofma thofma merged commit 73816e6 into master Aug 1, 2023
7 of 12 checks passed
@thofma thofma deleted the adv/serialize-laurent branch August 1, 2023 11:57
wdecker pushed a commit that referenced this pull request Aug 4, 2023
* Added Laurent Mpoly elem and ideals to serialization

* Tests for LaurentMPoly rings and their ideals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants