Fix parsing invalid href

[grandeljay]

This is my attempt to fix #501

In this case, I'd create a helper, so it can be used in other places. Something like:

@oscarotero I wasn't sure what exactly you mean, but maybe something like this?

[grandeljay]

Sorry you had to see that. This time I tested my changes.

I'm also wondering if it would make sense to use the splat operator so we could use

if (self::isEmpty($language, $href)) {

instead?

private function isEmpty(string ...$values): bool
{
    $skipValues = array(
        'undefined',
    );

    foreach ($values as $value) {
        if (empty($value) || in_array($value, $skipValues)) {
            return true;
        }
    }

    return false;
}

[oscarotero]

I'm also wondering if it would make sense to use the splat operator

Ok, but the arguments can be of any type, not only string (it must return true for null, 0, [], etc).

The isEmpty function shouldn't be a private method but a function that can be imported by other classes. The global helpers are located in this file: https://github.com/oscarotero/Embed/blob/master/src/functions.php

[grandeljay]

Ok, but the arguments can be of any type, not only string (it must return true for null, 0, [], etc).

getAttribute() seems to return a nullable string. If this helper is just used for this method, I think requiring a string parameter makes sense.

If you want to make the helper more "future proof" by allowing all types, I don't think we can continue to use empty() since it

Returns true if var does not exist or has a value that is empty or equal to zero, aka falsey [...]

So null, 0 and [] would be considered empty values which you do not seem to want.

The isEmpty function shouldn't be a private method but a function that can be imported by other classes. The global helpers are located in this file: https://github.com/oscarotero/Embed/blob/master/src/functions.php

Thanks! I'll change it!

[oscarotero]

Looks good to me. Thanks!