There is a problem with the configuration. #196
Conversation
Replaced by the directory name
| @@ -26,11 +26,11 @@ const gitInfo = () => { | |||
| */ | |||
| const writePackage = async (template, { user, email }) => { | |||
| let pkg = {} | |||
| const name = baseName(process.cwd()) | |||
| const source = `src/${name}.${template}` | |||
| let name = baseName(process.cwd()) | |||
There was a problem hiding this comment.
Is there a better way to keep const?
There was a problem hiding this comment.
how about split on path.delimiter?
There was a problem hiding this comment.
Is it possible to process / and \ separately?
And I think we need to resolve the overwrite of the name in pkg.name.
There was a problem hiding this comment.
The overwrite is already handled in merge right after.
The path separator is platform specific if you use path.delimiter linked above.
There was a problem hiding this comment.
Even after merge
You need to fix the part where the name value is kept as the system folder name.
There was a problem hiding this comment.
It is set as const name in all the codes below.
However, if pkg.name exists
name must be replaced with pkg.name
Is my opinion correct?
There was a problem hiding this comment.
const name = process.cwd().split('/').pop()
const source = `src/${name}.${template}`
if (exists('./package.json')) {
pkg = JSON.parse(await read('./package.json'))
}
pkg = merge(
{
name,
version: '0.0.0',
license: 'MIT',
description: name,
type: 'module',
exports: {
'.': {
browser: `./dist/${name}.js`,
import: `./dist/${name}.js`,
require: `./dist/${name}.cjs.js`,
umd: `./dist/${name}.umd.js`,
},
'./': './',
'./package.json': './package.json',
},
keywords: [name],
},
pkg
)yes pkg merged.
But
name is replaced with
const name = process.cwd().split('/').pop()
Is this what you intended?
There was a problem hiding this comment.
oh my bad, I did not see the subsequent usage.
There was a problem hiding this comment.
and now that I see it, I think there are more cases where this will break.
There was a problem hiding this comment.
I'll go to your house and try!
thx!
|
👋 @fro9-dev thank you for the catch. |
the package name is derived from current working directory and operations on directory paths should use correct separator based on platform re #196
|
@fro9-dev can you try the latest version 6.1.1 on windows and see if you still see an issue. |
|
All my problems have been solved. I'll close this PR. Thank you for your quick feedback 👋 |
No description provided.