Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport logging improvements #94

Merged
merged 3 commits into from
Oct 5, 2017

Conversation

mtyni
Copy link
Contributor

@mtyni mtyni commented Sep 28, 2017

Improvements to transport logging. (Listed in more detail in issue https://jira.nls.fi/browse/AH-4035)

…ix. Default global values are:

 -Timeout for job is 25 seconds
 -Circuit breaker is activated for 20 seconds if 5 requests fail in 100 seconds window.
@@ -519,7 +519,7 @@ public ReferencedEnvelope createEnlargedEnvelope(double width, double height) {
@JsonIgnore
public ReferencedEnvelope getEnlargedEnvelope() {
if(this.enlargedEnvelope == null) {
log.error("Enlarged envelope not created");
log.warn("Enlarged envelope not created");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be logged as just debug.

@ZakarFin ZakarFin added this to the 1.45.0 milestone Oct 5, 2017
@ZakarFin
Copy link
Member

ZakarFin commented Oct 5, 2017

Note that this includes changes from PR #92 as well. PRs should only include commits for single change.

@ZakarFin ZakarFin merged commit 504f6ae into oskariorg:develop Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants