Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix the internal usage of the value from --cmd flag #67

Merged
merged 4 commits into from
Apr 5, 2023
Merged

fix: Fix the internal usage of the value from --cmd flag #67

merged 4 commits into from
Apr 5, 2023

Conversation

xmnlab
Copy link
Member

@xmnlab xmnlab commented Apr 5, 2023 •
edited
Loading

Pull Request description

This PR aims to fix the internal usage of the value from --cmd flag using shlex

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .

@xmnlab xmnlab merged commit ac8a048 into osl-incubator:main Apr 5, 2023
@xmnlab xmnlab deleted the fix-cmd branch April 5, 2023 04:26
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

🎉 This PR is included in version 1.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

xmnlab added a commit that referenced this pull request Apr 7, 2023
@xmnlab
fix: Fix the internal usage of the value from --cmd flag (#67)
b497de9 
* fix: Fix cmd parameter usage

* Use shlex

* Fix issues

* fix unittest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xmnlab