Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add separate toggles for AWS ECR and GHCR #32

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

staticaland
Copy link
Collaborator

@staticaland staticaland commented Oct 16, 2023

Add inputs that toggle login and push.

Important

This removes the inputs push, aws_ecr_enable and ghcr_enable and replaces it with aws_ecr_login, aws_ecr_push, ghcr_login, ghcr_push. You MUST update your caller workflow to use these new inputs.

Example:

    with:
      environment: pirates-dev-ecr
      file: docs/Dockerfile

      region: eu-west-1
      aws_ecr_login: true
      aws_ecr_push: true
      ecr_repository_name: pirates-dev-km

      ghcr_login: true
      ghcr_push: true
      ghcr_image_name: "${{ github.repository }}/km"

Motivation and Context

Closes #30

@staticaland staticaland requested a review from a team as a code owner October 16, 2023 13:13
@staticaland staticaland merged commit 8a93c3e into main Oct 16, 2023
@staticaland staticaland deleted the 30-login-push-toggle branch October 16, 2023 13:21
This was referenced Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggles for login and push to different repositories
2 participants