Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove non-functional IMAGE_DIGEST #59

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

yngvark
Copy link
Contributor

@yngvark yngvark commented Feb 12, 2024

The docker-meta output cannot possibly contain the image digest, since it is only known after building an image.

IMAGE_DIGEST=${{ fromJSON(steps.docker-meta.outputs.json).labels['org.opencontainers.image.digest'] }}

Image digest is an output of the build-push step, so it cannot be used as a docker build arg.

@yngvark yngvark requested a review from a team as a code owner February 12, 2024 14:53
@yngvark yngvark merged commit 167e598 into main Feb 13, 2024
1 check passed
@yngvark yngvark deleted the 0-remove_image_digest branch February 13, 2024 15:41
@github-actions github-actions bot mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants