Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include PR #11224 from cosmos-sdk to fix Ledger/Amino authz signing #1434

Closed
george-aj opened this issue May 5, 2022 · 3 comments · Fixed by osmosis-labs/cosmos-sdk#224
Closed
Assignees

Comments

@george-aj
Copy link
Contributor

Hi,

Would it be possible to include the following PR cosmos/cosmos-sdk#11224 into the next release? This would fix the Ledger/Amino authz MsgGrant signing issues that are currently impacting all Ledger users.

Geo

@p0mvn
Copy link
Member

p0mvn commented May 5, 2022

Hi @george-aj . Taking a look... The desired PR related to this seems to be: cosmos/cosmos-sdk#11680

As a side note, this article was helpful for understanding the context: https://medium.com/confio/authz-and-ledger-signing-an-executive-summary-8754a0dc2a88

@p0mvn p0mvn self-assigned this May 5, 2022
@ValarDragon
Copy link
Member

@alexanderbez thoughts on whether this is a good idea to add directly to next release, vs wait until a subsequent release with SDK v0.46 ?

i don't understand whats happening with RegisterLegacyAminoJson being added into every module (vs just Authz)

@alexanderbez
Copy link
Contributor

I think @p0mvn's PR introduces the changes we need, but also introduces some API breaking changes. We can get it into v8.

Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants