-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Minor releases should sync through more blocks pre-release #2295
Comments
Hey @ValarDragon, thanks for the issue. I like the idea of running the check for more extended periods before a release. I had a more basic approach to addressing this problem: This is simpler to implement as it is only a tiny variation of our current CI, and we would not need to have a post-upgrade snapshot. At the same time:
What I like about this though, it's that the CI offers If it's okay with you, we can start with this solution first and then modifying to begin at earlier block heights. |
Does anyone other than myself have a state sync script? I favor Dev's approach, and use it widely on other chains. It is a safe way to check for app hash errors. It requires linking a physical machine into ci because otherwise it takes forever and a day. |
@niccoloraspa is there any updates on the path we are looking to go with this? |
I have moved this task to our board. |
It's tracked here for reference: https://github.com/osmosis-labs/osmosis-ci/issues/13 |
Background
Currently we have a CI workflow that runs epoch block + 1000 blocks on every commit to latest release branch. This is great for testing!
We should also have a CI flow that we can use pre-release that syncs through every available block on that branch. (So we make a snapshot of state at a height slightly after upgrade or upgrade directly)
This will increase our pre-release mainnet sync's battery of tests, from 1000 blocks (+ simulator after #2267 ) to all available blocks. The degree to which we can depend on this will depend on whats the syncing advantage factor, what degree we can parallelize the syncs, etc.
Suggested Design
Make a CI workflow we can use to try syncing a node with a given branch, from pre-configured start height for that release (e.g. first block of v11 based on a snapshot) to some set end block OR latest block.
This can be something we manually require before tagging any minor or patch version
The text was updated successfully, but these errors were encountered: