Gather v12 QA items

[ValarDragon]

Background

Lets have two people independently check the diff from main and v11.x and gather the list of state machine / client relevant files that have changed (e.g. what matters, not docs updates or e2e / simulator)

We should have two people do this for the redundancy aspect

Then we make a QA strategy off of these.

[czarcas7ic]

In trying to keep this list as succinct as possible, I am also going to exclude commits that ONLY change tests and does not change the logic itself. Lmk if you agree

[czarcas7ic]

This is what I got on a first pass. I can go into depth about what specifically we should be testing, but I though the first step was going through each file and find the PRs that changed important files in ways that potentially changes logic / would just be good to double check:

Should Consider In QA

• Adds admin denom to tokenfactory wasm binding
• Twap wasm bindings
• Removed legacy sdk.Msg handlers
  • Maybe just double check this PR as a whole
• Proto gen changes
  • Saw some changes in epochs/types/query.pb.gw.go that caught my eye
• GetNextPoolID vs GetNextPoolNumberAndIncrement vs getNextPoolIdAndIncrement
• Add check for correct input asset denoms to CalcJoinPoolShares
• Amino serialization for Authz
• Add fixed gas cost for swaps
• Incentives CLI fix rewards-estimation
• Changes getToDistributeCoinsFromGauges so that it only iterate through all gauges once
• Refactor AddToExistingLock
• check coins are positive in lockup ValidateBasic
• Further validate basics for lockup
• FundCommunityPoolFromModule in the pool-incentives module calls FundCommunityPool in the Cosmos SDK now

Integrator Notes

• Moved from camelCase to snake_case for protobuf
• Deletes sender from a querySwapExactAmountInRequest

Random Stuff

• Added share_out_amount and token_in to MsgJoinPoolResponse, token_out to MsgExitPoolResponse, and JoinPoolNoSwap returns tokenIn sdk.Coins, sharesOut sdk.Int
• Twap as a whole should be tested
• x/epochs/keeper/keeper.go, why do we still require cdc in NewKeeper?
• Removed errors.go for epoch module, assume its desired just pointing it out
• Removed MaximalExactRatioJoinBroken in x/gamm/pool-models/internal/cfmm_common/lp.go, also assume its desired I just didn't know the context for it

[ValarDragon]

• osmomath/math.go (adding base is negative check), sanity check this should never happen
• gamm proto fields being made to be snake case instead of camel case. (Need to figure out how to make this not an ecosystem break)
• Review gamm proto message responses (were they done correctly / as you'd expect?)
• proto/superfluid - check if we deleted some queries? Unclear to me on quick skim
• TokenFactory setDenomMetadata message. I remain worried about unclarity around bank registry, I think we just setup another registry for display data.
• TWAP
• Review wasmbinding differences
  {app/wasm => wasmbinding}/README.md | 6 +-
  {app/wasm => wasmbinding}/bindings/msg.go | 2 +-
  {app/wasm => wasmbinding}/bindings/pool.go | 2 +-
  {app/wasm => wasmbinding}/bindings/query.go | 44 +-
  {app/wasm => wasmbinding}/bindings/types.go | 2 +-
  {app/wasm => wasmbinding}/bindings/types_test.go | 2 +-
  {app/wasm => wasmbinding}/message_plugin.go | 42 +-
• x/epochs difference - https://github.com/osmosis-labs/osmosis/blob/main/x/epochs/keeper/abci.go#L19-L21
• x/gamm
  • What happened to the README?
  • Sanity check that messages still work, as we deleted the handler and now use Stargate handling for messages
    • Double check if we have go tests based on msg / tx execution
  • review ctx.GasMeter().ConsumeGas(types.BalancerGasFeeForSwap, "balancer swap computation")
  • https://github.com/osmosis-labs/osmosis/blob/main/x/gamm/pool-models/balancer/pool.go#L692-L698
  • Double check stableswap messages are still disabled
• x/incentives
  • TODO
• x/lockup
  • TODO
• x/pool-incentives
  • TODO
• x/superfluid
  • TODO
• x/tokenfactory
  • TODO
• x/TWAP
  • Review logic
  • Review safety of all external module calls & arithmetic (no panics should be possible in beginblock/endblock)
• Cosmwasm stargate queries
• Tests for items in v12 upgrade handler

[czarcas7ic]

Write single tracker issue of items people can test indv

[p0mvn]

Requesting one more review on this SDK PR please if anyone has time: osmosis-labs/cosmos-sdk#265

[p0mvn]

This can now be closed

[alexanderbez]

Woohooo nice work team!