Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x/stableswap] Precision tests for both stableswap CFMM solvers #2592

Closed
Tracked by #1451
AlpinYukseloglu opened this issue Sep 4, 2022 · 1 comment
Closed
Tracked by #1451

[x/stableswap] Precision tests for both stableswap CFMM solvers #2592

AlpinYukseloglu opened this issue Sep 4, 2022 · 1 comment
Labels
C:x/gamm Changes, features and bugs related to the gamm module.

Comments

@AlpinYukseloglu
Copy link
Contributor

Background

Our stableswap CFMM solvers (direct and binary search) hit precision-related issues on edge cases. This is especially a problem for our binary search solver as it risks hitting an infinite loop. #2591 should solve this, but we should make sure we have extensive edge case tests around precision-related issues to make sure our core stableswap CFMM solvers always function as intended.

Note: this issue is blocked on #2591

Suggested Design

  • Add tests for extremely high k values to stableswap solvers (at least one test for k > 100,000,000, ideally even for k = MaxDec)
  • Other edge case tests relating to multi-asset pools, different scaling factors etc.

Acceptance Criteria

  • All existing and new tests should pass
@AlpinYukseloglu AlpinYukseloglu added the C:x/gamm Changes, features and bugs related to the gamm module. label Sep 4, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Sep 4, 2022
@AlpinYukseloglu AlpinYukseloglu mentioned this issue Sep 4, 2022
Closed
55 tasks
@AlpinYukseloglu
Copy link
Contributor Author

This issue is addressed by #2776 and #2591

Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:x/gamm Changes, features and bugs related to the gamm module.
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlpinYukseloglu