Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stableswap]: Deprecate old solvers once binary search solvers are merged #2826

Closed
Tracked by #1451
AlpinYukseloglu opened this issue Sep 22, 2022 · 1 comment
Closed
Tracked by #1451

[stableswap]: Deprecate old solvers once binary search solvers are merged #2826

AlpinYukseloglu opened this issue Sep 22, 2022 · 1 comment
Labels
C:stableswap

Comments

@AlpinYukseloglu
Copy link
Contributor

AlpinYukseloglu commented Sep 22, 2022 •
edited
Loading

Background

Once our core solvers are pointed to our binary search solvers (#1341), we should delete any use or implementation of our original solvers. This should leave us with the implementation we use (binary search) and a direct solver (the simplified solvers from #2696 and #2730).

Suggested Design

  • Ensure all uses of our old manual solvers are removed from our codebase

Acceptance Criteria

  • All stableswap tests pass
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Sep 22, 2022
This was referenced Sep 22, 2022
Closed
Closed
Closed
@AlpinYukseloglu
Copy link
Contributor Author

Closed by #2845 (will still keep simplified solvers around for reference)

Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:stableswap
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlpinYukseloglu