You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Scaling/descaling can serve as a convenient place to convert inputs and outputs to/from BigDec for core stableswap math. Once we make this change, we should ensure that the only conversions to and from BigDec happen through the scaling functions.
Suggested Design
Make scaling functions do SDKDec -> BigDec and descaling do BigDec -> SDKDec
Acceptance Criteria
All conversions to and from BigDec happen under scaling functions
All existing and new tests pass
The text was updated successfully, but these errors were encountered:
It just occurred to me that this might not be fully possible since we directly interact with the PoolI interface for single asset joins @ValarDragon
Am I right in assuming that if we want to use scaling/descaling functions to gate SDKDec <-> BigDec conversions (and do all internal calculations with BigDec), we would have to create a BigDecCoin implementation and an internal pool interface that supports it?
Background
Scaling/descaling can serve as a convenient place to convert inputs and outputs to/from
BigDec
for core stableswap math. Once we make this change, we should ensure that the only conversions to and fromBigDec
happen through the scaling functions.Suggested Design
SDKDec
->BigDec
and descaling doBigDec
->SDKDec
Acceptance Criteria
BigDec
happen under scaling functionsThe text was updated successfully, but these errors were encountered: