Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x/gamm][stableswap]: Add scaling factors to inverse relationship tests #3005

Closed
Tracked by #1451
AlpinYukseloglu opened this issue Oct 16, 2022 · 0 comments
Closed
Tracked by #1451

[x/gamm][stableswap]: Add scaling factors to inverse relationship tests #3005

AlpinYukseloglu opened this issue Oct 16, 2022 · 0 comments
Labels
C:stableswap C:x/gamm Changes, features and bugs related to the gamm module.

Comments

@AlpinYukseloglu
Copy link
Contributor

Background

Our inverse relationship tests for stableswap currently do not incorporate scaling factors (hard-coded to factors of 1). We should expand these tests to ensure that uneven scaling factors do not break our stableswap inverse relationship.

Suggested Design

  • Abstract scaling factors into test field and add cases

Acceptance Criteria

  • All new and existing tests pass
@AlpinYukseloglu AlpinYukseloglu added C:x/gamm Changes, features and bugs related to the gamm module. C:stableswap labels Oct 16, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Oct 16, 2022
This was referenced Oct 16, 2022
Closed
Merged
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:stableswap C:x/gamm Changes, features and bugs related to the gamm module.
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlpinYukseloglu