Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL][Concentrated Liquidity Module]: implement swap keeper methods and connect with the swap-router #3063

Closed
p0mvn opened this issue Oct 19, 2022 · 5 comments
Closed

[CL][Concentrated Liquidity Module]: implement swap keeper methods and connect with the swap-router #3063

p0mvn opened this issue Oct 19, 2022 · 5 comments
Assignees
@p0mvn
Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:task ⚙️ A task belongs to a story
Milestone
CL 3: Swap Routin...

Comments

@p0mvn
Copy link
Member

p0mvn commented Oct 19, 2022

Background

Swap router modules routes swaps either to gamm or concentrated-liquidity. Therefore, we need to implement and connect swap methods in the concentrated-liquidity module.

Acceptance Criteria

  • swap keeper methods added
  • integrated to the swap-router module
@p0mvn p0mvn added C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board labels Oct 19, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Oct 19, 2022
@p0mvn p0mvn mentioned this issue Oct 19, 2022
Closed
@p0mvn
Copy link
Member Author

p0mvn commented Oct 19, 2022

blocked by: #3066

@catShaark catShaark self-assigned this Oct 20, 2022
@czarcas7ic
Copy link
Member

@catShaark we are going to keep all concentrated liquidity items in house for now, since we are all co-located to implement this feature. Will let you know if this changes, thanks for picking this up though!

@catShaark
Copy link
Contributor

ohhh, thanks for notifying me

@p0mvn p0mvn added the T:task ⚙️ A task belongs to a story label Oct 20, 2022
@p0mvn p0mvn mentioned this issue Oct 20, 2022
Merged
@mattverse
Copy link
Member

@catShaark thank you for everything!

@p0mvn p0mvn assigned mattverse and p0mvn and unassigned mattverse Oct 22, 2022
@p0mvn p0mvn mentioned this issue Oct 24, 2022
Merged
@p0mvn
Copy link
Member Author

p0mvn commented Oct 25, 2022

Further progress on this blocked by pool id routing. TBD in #3097

Some work towards this has been done in #3128 so I'm going to close is. Will create new issue after #3097 if still applicable

@p0mvn p0mvn closed this as completed Oct 25, 2022
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0mvn p0mvn

Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:task ⚙️ A task belongs to a story
Projects
Osmosis Chain Development
Archived in project
Milestone
CL 3: Swap Routing, Generalized Mint ...
Development

No branches or pull requests
4 participants
@p0mvn @czarcas7ic @mattverse @catShaark