Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL][Misc]: consider removing "pool_count" index and NumPools query from gamm #3240

Closed
p0mvn opened this issue Nov 4, 2022 · 2 comments
Closed

[CL][Misc]: consider removing "pool_count" index and NumPools query from gamm #3240

p0mvn opened this issue Nov 4, 2022 · 2 comments
Labels
C:x/gamm Changes, features and bugs related to the gamm module. F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@p0mvn
Copy link
Member

p0mvn commented Nov 4, 2022

Background

It is questionable whether NumPools query in x/gamm has any use to clients.
Currently, we store an additional index to keep track of this count.

Suggested Design

We should consider removing this query from x/gamm and the pool_count store index.

Acceptance Criteria

  • Decision is made
  • If decided to remove, all of the store index, relevant methods, queries and CLI are deleted
@p0mvn p0mvn added C:x/gamm Changes, features and bugs related to the gamm module. F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board labels Nov 4, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Nov 4, 2022
@p0mvn
Copy link
Member Author

p0mvn commented Nov 4, 2022

If no argument for keeping the "NumPools" query in x/gamm is made in the next few days, I propose we remove it.

This was referenced Nov 4, 2022
Closed
Merged
@hieuvubk
Copy link
Contributor

Hi if we got final decision about this issue, I'm willing to work with it

@p0mvn p0mvn mentioned this issue Nov 22, 2022
Merged
@p0mvn p0mvn closed this as completed Nov 23, 2022
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:x/gamm Changes, features and bugs related to the gamm module. F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@p0mvn @hieuvubk