-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(twap): edge case tests for geometric twap #3541
Comments
need to test this function: Line 39 in f9c3e06
where arithmeticMeanOfLogPrices is negative. It can happen when sp0 is < 1 |
Revisit this comment while working on this issue: https://github.com/osmosis-labs/osmosis/pull/3809/files#r1053921196 |
computeGeometricTwap
We need to test underflows. Context:
Originally posted by @ValarDragon in #3809 (comment) |
TODO: perform manual CLI test on completion |
Everything here has been complete but the manual test. Tracking manual test here: #3941 |
Background
Currently, most of the test cases for
computeGeometricTwap
use base values.To be more confident about correctness, we should add more test cases with hand-picked custom values.
This is an open-ended task so someone having context on the state of geometric twap should be working on this.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: