bug(CL): rounding behavior is incorrect, analyze other truncations and roundings

[p0mvn]

Background

The comment mentions that we need to round up but does banker's rounding. Instead, we need to first take Ceil() and then TruncateInt().

osmosis/x/concentrated-liquidity/swaps.go

Lines 330 to 333 in f2a497d

	// coin amounts require int values
	// round amountIn up to avoid under charging
	amt0 := tokenAmountInAfterFee.Sub(swapState.amountSpecifiedRemaining).RoundInt()
	amt1 := swapState.amountCalculated.TruncateInt()

osmosis/x/concentrated-liquidity/swaps.go

Lines 461 to 464 in f2a497d

	// coin amounts require int values
	// round amountIn up to avoid under charging
	amt0 := swapState.amountCalculated.TruncateInt()
	amt1 := desiredTokenOut.Amount.ToDec().Sub(swapState.amountSpecifiedRemaining).RoundInt()

Suggested Design

Fix the 2 problems

Review other calls to TruncateInt and RountInt in CL module to see if truncations/roundings are safe

Acceptance Criteria

• 2 examples fixed
• TruncateInt in CL module are analyzed and correct
• RountInt in CL module are analyzed and correct

[p0mvn]

These specific examples have been fixed, the rest should be investigated in internal review