Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please bump wasmvm to v1.2 and add cosmwasm_1_2 capability #4677

Closed
Tracked by #4700
larry0x opened this issue Mar 20, 2023 · 0 comments · Fixed by #4783
Closed
Tracked by #4700

Please bump wasmvm to v1.2 and add cosmwasm_1_2 capability #4677

larry0x opened this issue Mar 20, 2023 · 0 comments · Fixed by #4783
Assignees
@nicolaslara
Labels
Help wanted

Comments

@larry0x
Copy link
Contributor

larry0x commented Mar 20, 2023

Background

Instantiate2 is a very useful feature that comes with the latest version of CosmWasm. When instantiating a new contract, it allows the deployer to predict the contract's address beforehand.

In order to enable this feature, two changes are necessary:

Suggested Design

  1. Bump wasmvm dependency to v1.2.

  2. Add the cosmwasm_1_2 capability, like here: https://github.com/mars-protocol/hub/blob/v2.0.0-rc0/app/app.go#L509
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Mar 20, 2023
@p0mvn p0mvn mentioned this issue Mar 22, 2023
Closed
@p0mvn p0mvn moved this from Needs Triage 🔍 to Todo 🕒 in Osmosis Chain Development Mar 27, 2023
@nicolaslara nicolaslara moved this from Todo 🕒 to In Progress🏃 in Osmosis Chain Development Mar 28, 2023
@nicolaslara nicolaslara mentioned this issue Mar 29, 2023
Merged
@nicolaslara nicolaslara moved this from In Progress🏃 to Needs PR Review in Osmosis Chain Development Mar 29, 2023
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done ✅ in Osmosis Chain Development Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolaslara nicolaslara

Labels
Help wanted
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update wasmd to 0.31 osmosis-labs/osmosis
3 participants
@nicolaslara @larry0x @p0mvn