Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Should we use s. or suite. ? #5223

Closed
faddat opened this issue May 18, 2023 · 2 comments · Fixed by #5222
Closed

tests: Should we use s. or suite. ? #5223

faddat opened this issue May 18, 2023 · 2 comments · Fixed by #5222

Comments

@faddat
Copy link
Member

faddat commented May 18, 2023

In osmosis we have many tests, some are like:

suite *KeeperTestSuite

others are like

s *KeeperTestSuite

I've made a PR that tries to standardize around s, but fact is it doesn't matter one way or another which we do.

So I figured I would open an issue because what likely does matter is that we adhere to a standard:

@p0mvn
Copy link
Member

p0mvn commented May 18, 2023

I'm supportive of the consistency of using s everywhere

@faddat
Copy link
Member Author

faddat commented May 18, 2023

Then it shall be s. (unless others opine otherwise)

@faddat faddat changed the title Should we use s. or suite. ? tests: Should we use s. or suite. ? May 18, 2023
@faddat faddat mentioned this issue May 18, 2023
4 tasks
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants