Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/test: MonotonicSqrt function defined on osmomath.BigDec and benchmark against sdk.Dec #6045

Closed
Tracked by #5726
p0mvn opened this issue Aug 14, 2023 · 0 comments · Fixed by #6053
Closed
Tracked by #5726

feat/test: MonotonicSqrt function defined on osmomath.BigDec and benchmark against sdk.Dec #6045

p0mvn opened this issue Aug 14, 2023 · 0 comments · Fixed by #6053
Assignees
@p0mvn
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@p0mvn
Copy link
Member

p0mvn commented Aug 14, 2023 •
edited
Loading

Background

To raise the minimum spot price in CL, we need to implement a MonotonicSqrt function on osmomath.BigDec to support higher precision.

See design document: https://app.clickup.com/37420681/v/dc/13nzm9-22453/13nzm9-45853

Acceptance Criteria

  • Copy our existing sdk.Dec implementation, only changing sdk.Dec to osmomath.BigDec
  • Copy over tests
  • Benchmark against sdk.Dec version
@p0mvn p0mvn added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Aug 14, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Aug 14, 2023
@p0mvn p0mvn mentioned this issue Aug 14, 2023
Open
@p0mvn p0mvn changed the title feat/test: MonotonicSqrt function defined on osmomath.BigDec feat/test: MonotonicSqrt function defined on osmomath.BigDec and benchmark against sdk.Dec Aug 15, 2023
@p0mvn p0mvn mentioned this issue Aug 15, 2023
Merged
6 tasks
@p0mvn p0mvn self-assigned this Aug 16, 2023
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0mvn p0mvn

Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: monotonic sqrt big dec osmosis-labs/osmosis
1 participant
@p0mvn