Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(osmomath): introduce more mutative math helpers for BigDec #6370

Closed
p0mvn opened this issue Sep 11, 2023 · 3 comments · Fixed by #6409, #6428 or #6437
Closed

feat(osmomath): introduce more mutative math helpers for BigDec #6370

p0mvn opened this issue Sep 11, 2023 · 3 comments · Fixed by #6409, #6428 or #6437

Comments

@p0mvn
Copy link
Member

p0mvn commented Sep 11, 2023

Background

See the diff in this PR:
#6369

Notice TODOs marked with "TODO: (perf)"

We can optimize our math by creating mutative versions of the linked math helpers on BigDec that do not reallocate the internal buffer.

Suggested Design

For each individual helper, create a separate PR with the mutative versions that do not reallocate the internal buffer

Acceptance Criteria

@p0mvn
Copy link
Member Author

p0mvn commented Sep 11, 2023

Related work: #6261

@hieuvubk
Copy link
Contributor

@p0mvn Hi is anyone working on this?

@pysel
Copy link
Member

pysel commented Sep 13, 2023

hey @hieuvubk, I suppose it is free to pick up, since this has Help Wanted label! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment