Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query[CL]: UnderlyingPostionsValue #6650

Open
czarcas7ic opened this issue Oct 8, 2023 · 2 comments
Open

query[CL]: UnderlyingPostionsValue #6650

czarcas7ic opened this issue Oct 8, 2023 · 2 comments
Assignees

Comments

@czarcas7ic
Copy link
Member

Background

See the following comment for context #6623 (comment)

I added a UnderlyingPostionsValue method to help with some tests, but realized this would be really useful to expose as a query.

Suggested Design

The underlying logic is already completed in the UnderlyingPositionsValue method. One just has to wire this up to a respective query to expose via gRPC.

Acceptance Criteria

localosmosis tested against existing positions and the value returned makes sense. Preferable one in range, one above the current price, and one below the current price.

@pysel
Copy link
Member

pysel commented Oct 17, 2023

hey @czarcas7ic! I have a question on this one: should it be possible to provide a list of positions in CLI when querying [1], or should it only take a single position id as an argument [2]?

[1]: <...> underlying-positions-value 1,2,3
[2]: <...> underlying-positions-value 1

@czarcas7ic
Copy link
Member Author

@pysel sorry just now seeing this, I think either implementation is fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Triage 🔍
Development

Successfully merging a pull request may close this issue.

2 participants