Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The proto structs for Balancer should use snake_case #701

Closed
sunnya97 opened this issue Dec 29, 2021 · 6 comments · Fixed by #1656
Closed

The proto structs for Balancer should use snake_case #701

sunnya97 opened this issue Dec 29, 2021 · 6 comments · Fixed by #1656
Assignees
@hieuvubk

Comments

@sunnya97
Copy link
Collaborator

Currently, the field names all use camelCase, but I believe the standard we use for everything else is snake_case
@pwang00
Copy link
Collaborator

pwang00 commented Jan 9, 2022

Where are the proto structs located? I tried searching under osmosis/proto but I wasn't able to find any relevant info, but I may have missed something.

@ValarDragon
Copy link
Member

They're located in files in this directory: https://github.com/osmosis-labs/osmosis/tree/main/proto/osmosis/gamm

@hieuvubk
Copy link
Contributor

hieuvubk commented Jun 2, 2022

Did anyone done this issue?
@ValarDragon Could i countinue your work and close this issue ?

@ValarDragon
Copy link
Member

Yes please go for it!

@hieuvubk hieuvubk mentioned this issue Jun 2, 2022
Merged
@hieuvubk
Copy link
Contributor

hieuvubk commented Jun 2, 2022

Yes please go for it!

#1656
could u review this pr

@alexanderbez
Copy link
Contributor

Our hero 🙌

@hieuvubk hieuvubk self-assigned this Jun 5, 2022
@nghuyenthevinh2000 nghuyenthevinh2000 mentioned this issue Jun 16, 2022
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hieuvubk hieuvubk

Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Proto: camelCase to snake_case
5 participants
@sunnya97 @alexanderbez @ValarDragon @pwang00 @hieuvubk