You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are several places in the codebase (CLI folders) where we ad-hoc write parsing of a comma-delimited string into []uint64 ro []sdk.Int. We should have a single method we call for this, not ad-hoc implemented in line.
There are several places in the codebase (CLI folders) where we ad-hoc write parsing of a comma-delimited string into
[]uint64
ro[]sdk.Int
. We should have a single method we call for this, not ad-hoc implemented in line.The function for
[]uint64
is written here:osmosis/cmd/osmosisd/cmd/balances_from_state_export.go
Lines 343 to 358 in 8342388
We should move that function and write one for SDK.Int in
https://github.com/osmosis-labs/osmosis/blob/main/osmotestutils/cli_helpers.go
We should then switch
balances_from_state_export
, and pool incentives CLI's to use this.This is implemented in-line in the pool-incentives CLI code here: https://github.com/osmosis-labs/osmosis/blob/main/x/pool-incentives/client/cli/tx.go#L49-L69 & https://github.com/osmosis-labs/osmosis/blob/main/x/pool-incentives/client/cli/tx.go#L143-L163
The text was updated successfully, but these errors were encountered: