You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Due to the way we handle position transfers manually, it seems as though forfeited incentives are trickier to handle under the "redeposit forfeited incentives" design we're switching to. Since the position is not technically being removed, redepositing these incentives directly would be odd (e.g. the original position would still get a pro-rata portion).
Instead, it seems appropriate to simply retain the incentives in the transferred position if we're able to find a way to do it safely.
Suggested Design
At a first glance, it seems as though simply not collecting incentives before the transfer (i.e. removing the code below) should be sufficient:
We should double check this to make sure that it does not lead to any unintended behavior. It is technically also possible that we send to community pool here, but this feels inelegant and would reintroduce some of the problems that prompted the change to redepositing forfeited incentives.
Acceptance Criteria
Incentive forfeiting for positions transfers are handled properly
The text was updated successfully, but these errors were encountered:
Background
Due to the way we handle position transfers manually, it seems as though forfeited incentives are trickier to handle under the "redeposit forfeited incentives" design we're switching to. Since the position is not technically being removed, redepositing these incentives directly would be odd (e.g. the original position would still get a pro-rata portion).
Instead, it seems appropriate to simply retain the incentives in the transferred position if we're able to find a way to do it safely.
Suggested Design
At a first glance, it seems as though simply not collecting incentives before the transfer (i.e. removing the code below) should be sufficient:
osmosis/x/concentrated-liquidity/position.go
Lines 711 to 713 in be76d37
We should double check this to make sure that it does not lead to any unintended behavior. It is technically also possible that we send to community pool here, but this feels inelegant and would reintroduce some of the problems that prompted the change to redepositing forfeited incentives.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: